Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1528383004: Remove SkImageMinRowBytes (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkImageMinRowBytes As stated in the comments in crrev.com/1379193002, this method name is misleading. It returns a larger number than the minimum rowbytes - it increases to the next four-byte alignment. This has the effect that the one place that calls it does not support 565 (which is not already four-byte aligned), but does not serve any other purpose. Remove it and the only call-site. BUG=skia:4396 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1528383004 Committed: https://skia.googlesource.com/skia/+/db7dc09e526e815ade242e3dcb066693c42c8bda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/image/SkImagePriv.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tests/ImageFrom565Bitmap.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
5 years ago (2015-12-16 22:46:26 UTC) #3
reed1
lgtm
5 years ago (2015-12-17 14:03:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528383004/1
5 years ago (2015-12-18 14:38:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-18 14:56:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/db7dc09e526e815ade242e3dcb066693c42c8bda

Powered by Google App Engine
This is Rietveld 408576698