Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1528363002: Update documentation on Stream.map (Closed)

Created:
5 years ago by Lasse Reichstein Nielsen
Modified:
5 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M sdk/lib/async/stream.dart View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
5 years ago (2015-12-16 13:36:15 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1528363002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/1528363002/diff/1/sdk/lib/async/stream.dart#newcode317 sdk/lib/async/stream.dart:317: * will provide a data event with the ...
5 years ago (2015-12-16 13:39:35 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1528363002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/1528363002/diff/1/sdk/lib/async/stream.dart#newcode317 sdk/lib/async/stream.dart:317: * will provide a data event with the value ...
5 years ago (2015-12-16 13:45:11 UTC) #4
Lasse Reichstein Nielsen
5 years ago (2015-12-16 13:46:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ba675bddf2e60acfca1c12956c689c54de41547d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698