Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1528253002: Force a WM_NCCALCSIZE to occur when we receive a WM_DISPLAYCHANGE notification. (Closed)

Created:
5 years ago by ananta
Modified:
5 years ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force a WM_NCCALCSIZE to occur when we receive a WM_DISPLAYCHANGE notification. The WM_DISPLAYCHANGE message is sent when monitors are added/removed. Forcing a WM_NCCALCSIZE message to occur ensures that autohide data is recalculated which ensures that autohide taskbars continue to popup when we hover near the bottom of the window when chrome is maximized. BUG=472139 TEST=Connect two monitors. Run Chrome on one monitor and maximize it. Set the taskbar to autohide. Observe that taskbar pops up when we hover near the bottom. Now disconnect the monitor where Chrome is running. The window should move to the other monitor. Observe that the autohide taskbar continues to work. TBR=sky Committed: https://crrev.com/da8843e4e8fe12e5f45eb207622045a4a473c525 Cr-Commit-Position: refs/heads/master@{#365742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
ananta
5 years ago (2015-12-16 02:39:23 UTC) #2
ananta
TBR'ing sky. This is a low risk change. Will address comments in a followup
5 years ago (2015-12-17 02:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528253002/1
5 years ago (2015-12-17 02:45:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 04:06:09 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 04:07:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da8843e4e8fe12e5f45eb207622045a4a473c525
Cr-Commit-Position: refs/heads/master@{#365742}

Powered by Google App Engine
This is Rietveld 408576698