Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1528183003: Fix devenv tests (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Fix devenv tests testGit was using a string where a regular expression was intended. Committed: https://chromium.googlesource.com/webports/+/70638924e8a7e3ddbabc7a6d82851570ef792a1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ports/devenv/tests/devenv_large_test.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Sam Clegg
5 years ago (2015-12-15 23:33:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528183003/1
5 years ago (2015-12-15 23:33:26 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: webports-linux-glibc-5 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-glibc-5/builds/14)
5 years ago (2015-12-16 00:55:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528183003/1
5 years ago (2015-12-16 01:28:21 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-16 01:28:23 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528183003/1
5 years ago (2015-12-16 01:29:10 UTC) #12
binji
lgtm
5 years ago (2015-12-16 04:36:54 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 07:02:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528183003/1
5 years ago (2015-12-16 17:43:52 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-16 17:45:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/webports/+/70638924e8a7e3ddbabc7a6d82851570...

Powered by Google App Engine
This is Rietveld 408576698