Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3333)

Unified Diff: chrome/browser/resources/file_manager/background/js/background.js

Issue 152813004: [AudioPlayer] Enable new audio-player by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/background/js/background.js
diff --git a/chrome/browser/resources/file_manager/background/js/background.js b/chrome/browser/resources/file_manager/background/js/background.js
index adbac0a1631ab08fdd63a2e1c3a0727751707106..baa635af33d34d9e5671faae09c2d6d1ded39b93 100644
--- a/chrome/browser/resources/file_manager/background/js/background.js
+++ b/chrome/browser/resources/file_manager/background/js/background.js
@@ -691,29 +691,29 @@ var audioPlayer = null;
var audioPlayerInitializationQueue = new AsyncUtil.Queue();
audioPlayerInitializationQueue.run(function(callback) {
- chrome.commandLinePrivate.hasSwitch(
- 'file-manager-enable-new-audio-player',
- function(newAudioPlayerEnabled) {
- var audioPlayerHTML =
- newAudioPlayerEnabled ? 'audio_player.html' : 'mediaplayer.html';
-
- /**
- * Audio player window create options.
- * @type {Object}
- */
- var audioPlayerCreateOptions = Object.freeze({
- type: 'panel',
- hidden: true,
- minHeight: newAudioPlayerEnabled ? 116 : (35 + 58),
- minWidth: newAudioPlayerEnabled ? 292 : 280,
- height: newAudioPlayerEnabled ? 356 : (35 + 58),
- width: newAudioPlayerEnabled ? 292 : 280,
- });
+ // TODO(yoshiki): Remove '--file-manager-enable-new-audio-player' flag after
+ // the feature is launched.
+ var newAudioPlayerEnabled = true;
+
+ var audioPlayerHTML =
+ newAudioPlayerEnabled ? 'audio_player.html' : 'mediaplayer.html';
+
+ /**
hirono 2014/02/04 04:39:53 nit: Please fix indents. nit: Can we make it a glo
yoshiki 2014/02/04 06:32:12 Done
+ * Audio player window create options.
+ * @type {Object}
+ */
+ var audioPlayerCreateOptions = Object.freeze({
+ type: 'panel',
+ hidden: true,
+ minHeight: newAudioPlayerEnabled ? 116 : (35 + 58),
+ minWidth: newAudioPlayerEnabled ? 292 : 280,
+ height: newAudioPlayerEnabled ? 356 : (35 + 58),
+ width: newAudioPlayerEnabled ? 292 : 280,
+ });
- audioPlayer = new SingletonAppWindowWrapper(audioPlayerHTML,
- audioPlayerCreateOptions);
- callback();
- });
+ audioPlayer = new SingletonAppWindowWrapper(audioPlayerHTML,
+ audioPlayerCreateOptions);
+ callback();
});
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698