[AudioPlayer] Enable new audio-player by default

chrome/browser/resources/file_manager/background/js/background.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Number of runtime errors catched in the background page.
  * @type {number}
  */
@@ skipping 673 matching lines @@
 };
 
 // The instance of audio player. Until it's ready, this is null.
 var audioPlayer = null;
 
 // Queue to serializes the initialization, launching and reloading of the audio
 // player, so races won't happen.
 var audioPlayerInitializationQueue = new AsyncUtil.Queue();
 
 audioPlayerInitializationQueue.run(function(callback) {
-  chrome.commandLinePrivate.hasSwitch(
-      'file-manager-enable-new-audio-player',
-      function(newAudioPlayerEnabled) {
-        var audioPlayerHTML =
-            newAudioPlayerEnabled ? 'audio_player.html' : 'mediaplayer.html';
+  // TODO(yoshiki): Remove '--file-manager-enable-new-audio-player' flag after
+  // the feature is launched.
+  var newAudioPlayerEnabled = true;
 
-        /**
-         * Audio player window create options.
-         * @type {Object}
-         */
-        var audioPlayerCreateOptions = Object.freeze({
-          type: 'panel',
-          hidden: true,
-          minHeight: newAudioPlayerEnabled ? 116 : (35 + 58),
-          minWidth: newAudioPlayerEnabled ? 292 : 280,
-          height: newAudioPlayerEnabled ? 356 : (35 + 58),
-          width: newAudioPlayerEnabled ? 292 : 280,
-        });
+  var audioPlayerHTML =
+      newAudioPlayerEnabled ? 'audio_player.html' : 'mediaplayer.html';
 
-        audioPlayer = new SingletonAppWindowWrapper(audioPlayerHTML,
-                                                    audioPlayerCreateOptions);
-        callback();
-      });
+      /**

[hirono, 2014/02/04 04:39:53]

nit: Please fix indents.
nit: Can we make it a global constant?

[yoshiki, 2014/02/04 06:32:12]

Done
Would like to keep this patch small now. I'll do it when remove the flag.

+       * Audio player window create options.
+       * @type {Object}
+       */
+  var audioPlayerCreateOptions = Object.freeze({
+      type: 'panel',
+      hidden: true,
+      minHeight: newAudioPlayerEnabled ? 116 : (35 + 58),
+      minWidth: newAudioPlayerEnabled ? 292 : 280,
+      height: newAudioPlayerEnabled ? 356 : (35 + 58),
+      width: newAudioPlayerEnabled ? 292 : 280,
+  });
+
+  audioPlayer = new SingletonAppWindowWrapper(audioPlayerHTML,
+                                              audioPlayerCreateOptions);
+  callback();
 });
 
 /**
  * Launch the audio player.
  * @param {Object} playlist Playlist.
  */
 function launchAudioPlayer(playlist) {
   audioPlayerInitializationQueue.run(function(callback) {
     audioPlayer.launch(playlist);
     callback();
@@ skipping 111 matching lines @@
     contexts: ['launcher'],
     title: str('NEW_WINDOW_BUTTON_LABEL')
   });
 };
 
 /**
  * Singleton instance of Background.
  * @type {Background}
  */
 window.background = new Background();