Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 152813004: [AudioPlayer] Enable new audio-player by default (Closed)

Created:
6 years, 10 months ago by yoshiki
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[AudioPlayer] Enable new audio-player by default BUG=273308 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248688

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a comment #

Patch Set 3 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M chrome/browser/resources/file_manager/background/js/background.js View 1 1 chunk +22 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoshiki
hirono PTAL, thanks
6 years, 10 months ago (2014-02-04 04:37:50 UTC) #1
hirono
Congrats! lgtm with nits! https://codereview.chromium.org/152813004/diff/30001/chrome/browser/resources/file_manager/background/js/background.js File chrome/browser/resources/file_manager/background/js/background.js (right): https://codereview.chromium.org/152813004/diff/30001/chrome/browser/resources/file_manager/background/js/background.js#newcode701 chrome/browser/resources/file_manager/background/js/background.js:701: /** nit: Please fix indents. ...
6 years, 10 months ago (2014-02-04 04:39:53 UTC) #2
yoshiki
https://codereview.chromium.org/152813004/diff/30001/chrome/browser/resources/file_manager/background/js/background.js File chrome/browser/resources/file_manager/background/js/background.js (right): https://codereview.chromium.org/152813004/diff/30001/chrome/browser/resources/file_manager/background/js/background.js#newcode701 chrome/browser/resources/file_manager/background/js/background.js:701: /** On 2014/02/04 04:39:53, hirono wrote: > nit: Please ...
6 years, 10 months ago (2014-02-04 06:32:11 UTC) #3
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 10 months ago (2014-02-04 06:32:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/152813004/80001
6 years, 10 months ago (2014-02-04 06:33:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:14:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222887
6 years, 10 months ago (2014-02-04 07:14:35 UTC) #7
yoshiki
6 years, 10 months ago (2014-02-04 07:14:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r248688 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698