Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1528113002: Merge the prefix and references tables. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge the prefix and references tables. This makes the UnlinkedLibrary type go away, which means that we no longer have any unlinked summary data which is spread across the compilation units constituting a library. That in turn means that we should be able to safely re-link summaries even in the (pathological) case where a change to URI resolution affects the relationship between a library and its parts. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b22d7d532f89abdf5d0939d5e8b0b8b3d40a43c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -177 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 11 chunks +18 lines, -103 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 7 chunks +21 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 6 chunks +21 lines, -17 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 6 chunks +10 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years ago (2015-12-15 19:44:07 UTC) #2
scheglov
LGTM
5 years ago (2015-12-15 19:56:53 UTC) #3
Brian Wilkerson
LGTM
5 years ago (2015-12-15 20:26:30 UTC) #4
Paul Berry
5 years ago (2015-12-15 20:33:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b22d7d532f89abdf5d0939d5e8b0b8b3d40a43c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698