Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1528103002: Remove ScrollbarThemeClient repaint methods. (Closed)

Created:
5 years ago by jbroman
Modified:
5 years ago
Reviewers:
skobes, ccameron
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScrollbarThemeClient repaint methods. They are only called statically on Scrollbar; they can live there. Committed: https://crrev.com/9ead38caa821826f3302dfdb05309fbf870206a7 Cr-Commit-Position: refs/heads/master@{#365398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -33 lines) Patch
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbroman
This is defined on the ScrollbarThemeClient interface, but only ever used on a blink::Scrollbar explicitly. ...
5 years ago (2015-12-15 20:24:11 UTC) #2
skobes
lgtm
5 years ago (2015-12-15 21:15:57 UTC) #3
ccameron
On 2015/12/15 at 21:15:57, skobes wrote: > lgtm Sounds fair!
5 years ago (2015-12-15 21:59:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528103002/1
5 years ago (2015-12-15 22:25:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 00:10:59 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-16 00:12:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ead38caa821826f3302dfdb05309fbf870206a7
Cr-Commit-Position: refs/heads/master@{#365398}

Powered by Google App Engine
This is Rietveld 408576698