Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1528083002: Reserve element 0 in the references table for `dynamic`. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reserve element 0 in the references table for `dynamic`. In addition to simplifying some serialization/deserialization code, this paves the way for merging the references table with the prefixes table by allowing the zeroth entry in both tables to act as a sentinel value. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ceecfe862b5d5e459f8e1cb757d9e48439641a7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +8 lines, -21 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years ago (2015-12-15 19:14:41 UTC) #2
scheglov
LGTM
5 years ago (2015-12-15 19:16:48 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as ceecfe862b5d5e459f8e1cb757d9e48439641a7a (presubmit successful).
5 years ago (2015-12-15 19:25:16 UTC) #5
Brian Wilkerson
5 years ago (2015-12-15 20:22:28 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698