Chromium Code Reviews
Help | Chromium Project | Sign in
(31)

Issue 1528032: Add download item tooltips on linux/win. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
Glen Murphy, Nico
Visibility:
Public.

Description

Add download item tooltips on linux/win. BUG=41195 TEST=manual Committed: http://src.chromium.org/viewvc/44524

Patch Set 1 #

Patch Set 2 : fix views #

Patch Set 3 : don't show tooltip for dangerous downloads #

Patch Set 4 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/browser/gtk/download_item_gtk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/views/download_item_view.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 2 3 4 chunks +12 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Evan Stade
5 years, 1 month ago (2010-04-12 23:46:37 UTC) #1
Evan Stade
updated.
5 years, 1 month ago (2010-04-13 22:56:46 UTC) #2
Nico
(Code-wise this LG, I'm just waiting for Glen to give an UX ok (I doubt ...
5 years, 1 month ago (2010-04-13 22:58:58 UTC) #3
Glen Murphy
5 years, 1 month ago (2010-04-14 00:10:12 UTC) #4
> (Code-wise this LG, I'm just waiting for Glen to give an UX ok

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be