Issue 1528013004: Issue 25253. Improve collecting names that may conflict with the extracted local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1528013004: Issue 25253. Improve collecting names that may conflict with the extracted local variable. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -28 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	3 chunks	+23 lines, -15 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_local.dart	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_local_test.dart	View	4 chunks	+54 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

5 years ago (2015-12-15 20:26:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
70cd905c4dbe845f10f3f149190eb273aa56d8bf (presubmit successful).