Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527993002: Tidy up SVGParserUtilities (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up SVGParserUtilities Remove unused typedefs and includes. Move 'transform'-related parsing bits to SVGTransformList.cpp. Committed: https://crrev.com/0fc5d1ccadfb5e39cee14073ac4aef32e00d9012 Cr-Commit-Position: refs/heads/master@{#365379}

Patch Set 1 #

Patch Set 2 : Drop one more include. #

Patch Set 3 : Extra math for Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -79 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParserUtilities.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParserUtilities.cpp View 1 2 2 chunks +1 line, -59 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 4 chunks +54 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGZoomAndPan.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
Drive-by tidy
5 years ago (2015-12-15 16:53:25 UTC) #2
pdr.
Drive by LGTM
5 years ago (2015-12-15 21:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527993002/40001
5 years ago (2015-12-15 21:53:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 23:20:22 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 23:22:17 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0fc5d1ccadfb5e39cee14073ac4aef32e00d9012
Cr-Commit-Position: refs/heads/master@{#365379}

Powered by Google App Engine
This is Rietveld 408576698