Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1527863004: Don't build official Chrome on 'CFI Linux ToT' bot (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
Dirk Pranke, dpranke, pcc1
CC:
chromium-reviews, kcc1, pcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'CFI Linux ToT' buildbot: don't build an official Chrome there. The proper fix would be different, but after some thought, I decided that running an official Chrome build on the ToT clang is not the best idea. BUG=568384 Committed: https://crrev.com/8ff132ff52206e53781006d7764c644e8737eb70 Cr-Commit-Position: refs/heads/master@{#366198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
krasin
5 years ago (2015-12-16 06:39:59 UTC) #2
Dirk Pranke
I don't think 'chromium_builder_tests' exists as a target in GN at all, so I don't ...
5 years ago (2015-12-16 16:26:45 UTC) #4
Nico
On 2015/12/16 16:26:45, Dirk Pranke wrote: > I don't think 'chromium_builder_tests' exists as a target ...
5 years ago (2015-12-18 20:18:55 UTC) #6
Dirk Pranke
lgtm
5 years ago (2015-12-18 21:21:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863004/1
5 years ago (2015-12-18 22:02:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 23:15:01 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-18 23:16:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ff132ff52206e53781006d7764c644e8737eb70
Cr-Commit-Position: refs/heads/master@{#366198}

Powered by Google App Engine
This is Rietveld 408576698