Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1527863003:
[stubs] Fix TypeOfStub to properly return "undefined" for undetectable. (Closed)
|
Created:
5 years ago by Benedikt Meurer Modified:
5 years ago Reviewers:
Yang CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[stubs] Fix TypeOfStub to properly return "undefined" for undetectable.
The TypeOfStub didn't test the undetectable bit properly if the instance
was also callable, and therefore returned "object" for document.all
(which is both undetectable and callable).
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
R=yangguo@chromium.org
BUG=chromium:567998
LOG=n
Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc
Cr-Commit-Position: refs/heads/master@{#32852}
Committed: https://crrev.com/fa13da2e2b78086c1b643a7d76182e2ae8809294
Cr-Commit-Position: refs/heads/master@{#32883}
Patch Set 1 #
Messages
Total messages: 28 (13 generated)
Hey Yang, Small fix for typeof w/ undetectable and callable. Please take a look. Thanks, Benedikt
On 2015/12/15 07:22:20, Benedikt Meurer wrote: > Hey Yang, > > Small fix for typeof w/ undetectable and callable. > Please take a look. > > Thanks, > Benedikt lgtm.
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11509)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n ========== to ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1525703003/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Changes layout tests. Please fix upstream first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....
Message was sent while issue was closed.
Description was changed from ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ========== to ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ==========
Description was changed from ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ========== to ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ==========
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863003/1
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527863003/1
Message was sent while issue was closed.
Description was changed from ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ========== to ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} ========== to ========== [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:567998 LOG=n Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc Cr-Commit-Position: refs/heads/master@{#32852} Committed: https://crrev.com/fa13da2e2b78086c1b643a7d76182e2ae8809294 Cr-Commit-Position: refs/heads/master@{#32883} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fa13da2e2b78086c1b643a7d76182e2ae8809294 Cr-Commit-Position: refs/heads/master@{#32883} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
