Attempt to fix crash in base::android::MethodID::Get() (second attempt)

Attempt to fix crash in base::android::MethodID::Get().

First attempt to land this CL can be found in https://codereview.chromium.org/156353003/. I did a mistake which Ami found after I had committed. The first version was therefore reverted and this is the second attempt to land; this time without the bug that Ami found.

TBR=bulach
BUG=336600
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250093

[henrika (OOO until Aug 14), 2014-02-10 13:34:34]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-02-10 13:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-10 13:34:44]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[henrika (OOO until Aug 14), 2014-02-10 13:36:32]

Committed patchset #2 manually as r250093 (presubmit successful).

[Ami GONE FROM CHROMIUM, 2014-02-10 18:29:47]

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:216:
mIsInitialized = true;
You still aren't early-returning from the catch clause above, so this will
execute even if an exception is fired.

[henrika (OOO until Aug 14), 2014-02-10 19:33:36]

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:216:
mIsInitialized = true;
Yes, that is a design decision. We see this issue only on non-supported device
and I try to avoid a crash. mInitialized is true even if we catch an exception,
yes. All it means is that the volume-change functionality will not work on these
devices. I am OK with that. Are you?

[Ami GONE FROM CHROMIUM, 2014-02-10 19:42:29]

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:216:
mIsInitialized = true;
On 2014/02/10 19:33:40, henrika wrote:
> Yes, that is a design decision. We see this issue only on non-supported device
> and I try to avoid a crash. mInitialized is true even if we catch an
exception,
> yes. All it means is that the volume-change functionality will not work on
these
> devices. I am OK with that. Are you?

I assumed that one a WTF exception happened we would not try to continue to use
this sort of functionality (audio).
I don't feel strongly about this.

[henrika (OOO until Aug 14), 2014-02-10 20:02:18]

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
(right):

https://codereview.chromium.org/152783005/diff/60001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java:216:
mIsInitialized = true;
A valid comment. Yes, I could bail out early but the would disable all
enumeration for these special devices and tried to keep as much as possible.
Can't say that I like doing this patch but this is the best I can do for now.