Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1527793004: Provide list of service protocol extensions in isolate and emit an event when one is registered (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 8c9717faa4b309ea17fb9a407a6719bcf3440355..fe89cec77b144d727ecf315b5bc021d9128cdb07 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1171,6 +1171,8 @@ class Isolate extends ServiceObjectOwner with Coverage {
@observable bool ioEnabled = false;
+ final List<String> serviceExtensions = new List<String>();
+
Map<String,ServiceObject> _cache = new Map<String,ServiceObject>();
final TagProfile tagProfile = new TagProfile(20);
@@ -1436,6 +1438,10 @@ class Isolate extends ServiceObjectOwner with Coverage {
if (savedStartTime == null) {
vm._buildIsolateList();
}
+
+ serviceExtensions.clear();
+ serviceExtensions.addAll(map['serviceExtensions']);
+ libraries.sort(ServiceObject.LexicalSortName);
turnidge 2015/12/16 18:47:25 Is the libraries.sort line here on accident? Appe
Cutch 2015/12/16 21:19:56 Copy and paste bug. Removed.
}
Future<TagProfile> updateTagProfile() {
@@ -1884,6 +1890,8 @@ class ServiceEvent extends ServiceObject {
static const kIsolateRunnable = 'IsolateRunnable';
static const kIsolateExit = 'IsolateExit';
static const kIsolateUpdate = 'IsolateUpdate';
+ static const kIsolateServiceExtensionRegistered =
+ 'IsolateServiceExtensionRegistered';
static const kPauseStart = 'PauseStart';
static const kPauseExit = 'PauseExit';
static const kPauseBreakpoint = 'PauseBreakpoint';
@@ -1910,6 +1918,7 @@ class ServiceEvent extends ServiceObject {
@observable DateTime timestamp;
@observable Breakpoint breakpoint;
@observable Frame topFrame;
+ @observable String serviceExtensionName;
@observable Instance exception;
@observable Instance asyncContinuation;
@observable bool atAsyncJump;
@@ -1952,6 +1961,9 @@ class ServiceEvent extends ServiceObject {
breakpoint = pauseBpts[0];
}
}
+ if (map['serviceExtensionName'] != null) {
+ serviceExtensionName = map['serviceExtensionName'];
+ }
topFrame = map['topFrame'];
if (map['exception'] != null) {
exception = map['exception'];
« no previous file with comments | « no previous file | runtime/observatory/tests/service/developer_extension_test.dart » ('j') | runtime/vm/service_event.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698