Provide list of service protocol extensions in isolate and emit an event when one is registered

Provide list of service protocol extensions in isolate and emit an event when one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered (IsolateServiceExtensionRegistered).

Fixes https://dartbug.com/25208
Fixes https://dartbug.com/25257

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3ee7723081256d42c8981578f22e0f1a1ff05b1

[Cutch, 2015-12-15 19:22:51]

Description was changed from

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered
==========

to

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered
(IsolateServiceExtensionRegistered).
==========

[Cutch, 2015-12-15 19:22:51]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[Cutch, 2015-12-15 19:24:14]

Description was changed from

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered
(IsolateServiceExtensionRegistered).
==========

to

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered
(IsolateServiceExtensionRegistered).

Fixes https://dartbug.com/25208
Fixes https://dartbug.com/25257
==========

[turnidge, 2015-12-16 18:47:25]

We should update service.md as well, right?

https://codereview.chromium.org/1527793004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1527793004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1444:
libraries.sort(ServiceObject.LexicalSortName);
Is the libraries.sort line here on accident?  Appears to be duplicated above.

https://codereview.chromium.org/1527793004/diff/1/runtime/vm/service_event.cc
File runtime/vm/service_event.cc (right):

https://codereview.chromium.org/1527793004/diff/1/runtime/vm/service_event.cc...
runtime/vm/service_event.cc:107: return "IsolateServiceExtensionRegistered";
This name is a little long.  How about dropping "Isolate" and calling it
"ServiceExtensionRegistered".  It can still go on the Isolate stream without the
word Isolate in its name.

The name "ServiceExtensionAdded" would be shorter yet (and consistent with
BreakpointAdded) and it would leave the door open for adding a
"ServiceExtensionRemoved" event in the future if we want without using the bulky
verb "unregistered".  Your call.

[Cutch, 2015-12-16 21:19:56]

PTAL

https://codereview.chromium.org/1527793004/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1527793004/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1444:
libraries.sort(ServiceObject.LexicalSortName);
On 2015/12/16 18:47:25, turnidge wrote:
> Is the libraries.sort line here on accident?  Appears to be duplicated above.

Copy and paste bug. Removed.

https://codereview.chromium.org/1527793004/diff/1/runtime/vm/service_event.cc
File runtime/vm/service_event.cc (right):

https://codereview.chromium.org/1527793004/diff/1/runtime/vm/service_event.cc...
runtime/vm/service_event.cc:107: return "IsolateServiceExtensionRegistered";
On 2015/12/16 18:47:25, turnidge wrote:
> This name is a little long.  How about dropping "Isolate" and calling it
> "ServiceExtensionRegistered".  It can still go on the Isolate stream without
the
> word Isolate in its name.
> 
> The name "ServiceExtensionAdded" would be shorter yet (and consistent with
> BreakpointAdded) and it would leave the door open for adding a
> "ServiceExtensionRemoved" event in the future if we want without using the
bulky
> verb "unregistered".  Your call.

Done.

[turnidge, 2015-12-16 21:26:05]

lgtm

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service/serv...
File runtime/vm/service/service.md (right):

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service/serv...
runtime/vm/service/service.md:1143: // The method name of the service extension
that was added.
RPC name?

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service/serv...
runtime/vm/service/service.md:1146: string serviceExtensionName [optional];
extensionRPC

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service/serv...
runtime/vm/service/service.md:1824: // The list of service extension methods
that are registered on this isolate.
methods -> rpcs

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service/serv...
runtime/vm/service/service.md:1825: string[] serviceExtensions;
serviceExtensions -> extensionRPCs

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service_event.h
File runtime/vm/service_event.h (right):

https://codereview.chromium.org/1527793004/diff/20001/runtime/vm/service_even...
runtime/vm/service_event.h:102: const String* extension_name() const {
extension_rpc?

[turnidge, 2015-12-16 21:26:08]

lgtm

[Cutch, 2015-12-16 21:32:32]

lgtm

[Cutch, 2015-12-16 21:49:41]

Description was changed from

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered
(IsolateServiceExtensionRegistered).

Fixes https://dartbug.com/25208
Fixes https://dartbug.com/25257
==========

to

==========
Provide list of service protocol extensions in isolate and emit an event when
one is registered.

- Doc improvements.
- Type annotation improvements.
- Isolate includes list of currently registered extensions.
- New event kind on isolate stream emitted whenever an extension is registered
(IsolateServiceExtensionRegistered).

Fixes https://dartbug.com/25208
Fixes https://dartbug.com/25257

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3ee7723081256d42c8981578f22e0f1a1ff05b1
==========

[Cutch, 2015-12-16 21:49:42]

Committed patchset #4 (id:60001) manually as
f3ee7723081256d42c8981578f22e0f1a1ff05b1 (presubmit successful).