Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527793003: Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/56fe38f0abd91e13b505ec0a7c4f3142ef9b0680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -372 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 6 chunks +50 lines, -49 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart View 3 chunks +22 lines, -22 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 3 chunks +122 lines, -122 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 3 chunks +40 lines, -39 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +13 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/name_suggestion.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_range.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_label.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_library.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/element_visitors.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/hierarchy.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/element_writer.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/tree_writer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
As before, only import changes are real, anything else was sorting or formatting.
5 years ago (2015-12-15 01:19:37 UTC) #2
scheglov
LGTM
5 years ago (2015-12-15 01:28:37 UTC) #3
Paul Berry
lgtm
5 years ago (2015-12-15 02:38:41 UTC) #4
Brian Wilkerson
5 years ago (2015-12-15 03:31:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
56fe38f0abd91e13b505ec0a7c4f3142ef9b0680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698