Add helper for determining whether to use sized internal format in GL

Add helper for determining whether to use sized internal format in GL

Fix case where texture format and data format are different.

Use helper when createing a testing "backend" texture.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6176bc1df33684d0de028d25956caf925cf82b4a

[bsalomon, 2015-12-14 21:22:25]

bsalomon@google.com changed reviewers:
+ jvanverth@google.com

[bsalomon, 2015-12-14 21:22:26]

The motivation for this is to make A8 "backend testing" textures work on ES3
devices.

[jvanverth1, 2015-12-15 15:35:41]

lgtm + comments

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:663: * @param useTexStorage The result of a call to
can_use_tex_storage().
These param comments don't match this function.

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:731: desc.fConfig);
Nit: tab one space?

[bsalomon, 2015-12-15 17:09:47]

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:663: * @param useTexStorage The result of a call to
can_use_tex_storage().
On 2015/12/15 at 15:35:41, jvanverth1 wrote:
> These param comments don't match this function.

D'oh! Forgot to update when I changed the params.
Done.

https://codereview.chromium.org/1527753002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:731: desc.fConfig);
On 2015/12/15 at 15:35:41, jvanverth1 wrote:
> Nit: tab one space?

Done.

[bsalomon, 2015-12-15 17:09:53]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-12-15 17:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1527753002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-12-15 17:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527753002/20001

[commit-bot: I haz the power, 2015-12-15 17:25:08]

Description was changed from

==========
Add helper for determining whether to use sized internal format in GL

Fix case where texture format and data format are different.

Use helper when createing a testing "backend" texture.

BUG=skia:
==========

to

==========
Add helper for determining whether to use sized internal format in GL

Fix case where texture format and data format are different.

Use helper when createing a testing "backend" texture.

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/6176bc1df33684d0de028d25956caf925cf82b4a
==========

[commit-bot: I haz the power, 2015-12-15 17:25:08]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6176bc1df33684d0de028d25956caf925cf82b4a

[bsalomon, 2015-12-16 16:07:17]

+cblume. Just FYI, I cribbed this function from your MIP map CL but changed it a
little bit.