Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 15277005: Fixes for issues 10017 and 10161 (Closed)

Created:
7 years, 7 months ago by Brian Wilkerson
Modified:
7 years, 7 months ago
Reviewers:
jwren, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -67 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/Annotation.java View 2 chunks +16 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 22 chunks +207 lines, -67 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/SimpleResolverTest.java View 4 chunks +228 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
7 years, 7 months ago (2013-05-20 15:12:38 UTC) #1
scheglov
LGTM
7 years, 7 months ago (2013-05-20 15:30:26 UTC) #2
Brian Wilkerson
Committed patchset #1 manually as r22895 (presubmit successful).
7 years, 7 months ago (2013-05-20 18:01:14 UTC) #3
jwren
7 years, 7 months ago (2013-05-20 18:07:52 UTC) #4
Message was sent while issue was closed.
On 2013/05/20 15:30:26, scheglov wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld 408576698