Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Issue 1527673002: Cleanup: return by const reference instead of value in BufferedResourceLoader (Closed)

Created:
5 years ago by paul.sapunaru
Modified:
5 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: return by const reference instead of value in BufferedResourceLoader Small cleanup which replaces the const value with const reference return value of the reponse_original_url() function. BUG=568959 Committed: https://crrev.com/a4ac3d05c692c9f45898905294bbb23a48e647cd Cr-Commit-Position: refs/heads/master@{#365341}

Patch Set 1 #

Patch Set 2 : Added my name to the AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/buffered_resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
paul.sapunaru
Hi Dale, Can you please take a look at this small cleanup? Cheers, Paul
5 years ago (2015-12-14 16:36:49 UTC) #2
DaleCurtis
lgtm
5 years ago (2015-12-14 17:50:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527673002/1
5 years ago (2015-12-15 09:03:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/128965)
5 years ago (2015-12-15 09:10:52 UTC) #7
paul.sapunaru
Hi, Can you please take another look? Sorry, I didn't know the build will fail ...
5 years ago (2015-12-15 09:26:03 UTC) #8
DaleCurtis
Still lgtm, I've verified the CLA agreement is present.
5 years ago (2015-12-15 17:27:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527673002/20001
5 years ago (2015-12-15 19:22:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 21:44:21 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-15 21:45:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4ac3d05c692c9f45898905294bbb23a48e647cd
Cr-Commit-Position: refs/heads/master@{#365341}

Powered by Google App Engine
This is Rietveld 408576698