Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc

Issue 1527653004: Move browsing data counters helper functions to an 'utils' file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Default flag value. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler_unittest.cc b/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
similarity index 88%
rename from chrome/browser/ui/webui/options/clear_browser_data_handler_unittest.cc
rename to chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
index 64792aa0fb189134be81fefd1a6bb476c79b0751..589859fa2c8f68ea1ddb77501a49ea90fde90469 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/webui/options/clear_browser_data_handler.h"
+#include "chrome/browser/browsing_data/browsing_data_counter_utils.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -10,10 +10,10 @@
#include "chrome/test/base/testing_browser_process.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace options {
+namespace browsing_data {
// Tests the complex output of the Autofill counter.
-TEST(ClearBrowserDataTest, AutofillCounterResult) {
+TEST(BrowsingDataHelpersTest, AutofillCounterResult) {
Bernhard Bauer 2015/12/16 13:35:32 Should this be called BrowsingDataCounterUtilsTest
msramek 2016/01/05 16:22:50 Yes! I originally had the file named helpers :)
AutofillCounter counter;
// This test assumes that the strings are served exactly as defined,
@@ -55,10 +55,9 @@ TEST(ClearBrowserDataTest, AutofillCounterResult) {
test_case.num_suggestions
));
- base::string16 output = ClearBrowserDataHandler::GetCounterTextFromResult(
- &result);
+ base::string16 output = GetCounterTextFromResult(&result);
EXPECT_EQ(output, base::ASCIIToUTF16(test_case.expected_output));
}
}
-} // namespace options
+} // namespace browsing_data

Powered by Google App Engine
This is Rietveld 408576698