Source/web/WebViewImpl.cpp - Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase. Address some review comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 58736d2d9419ffdd4bd603af5535163be5073668..92e345c61d5f54db8306e94515d8d2a62c5b704d 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -120,6 +120,7 @@

#include "modules/geolocation/GeolocationController.h"

#include "modules/indexeddb/InspectorIndexedDBAgent.h"

#include "modules/notifications/NotificationController.h"

+#include "modules/pushmessaging/PushController.h"

#include "painting/ContinuousPainter.h"

#include "platform/ContextMenu.h"

#include "platform/ContextMenuItem.h"

@@ -412,6 +413,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

m_page->makeOrdinary();

if (m_client) {

+ providePushControllerTo(*m_page, m_client->webPushClient());

setDeviceScaleFactor(m_client->screenInfo().deviceScaleFactor);

setVisibilityState(m_client->visibilityState(), true);

}

« no previous file with comments | « Source/platform/RuntimeEnabledFeatures.in ('k') | public/platform/WebPushClient.h » ('j') | no next file with comments »