DO NOT REVIEW Bindings and plumbing for push messaging API.

Source/web/WebViewImpl.cpp

Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index bfa58740ba092e1c5f066fa3e5c83eb3814519c0..560882d5617c13681ee277b6c57e7b08c13c81cf 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -120,6 +120,7 @@
 #include "modules/geolocation/GeolocationController.h"
 #include "modules/indexeddb/InspectorIndexedDBAgent.h"
 #include "modules/notifications/NotificationController.h"
+#include "modules/pushmessaging/PushController.h"
 #include "painting/ContinuousPainter.h"
 #include "platform/ContextMenu.h"
 #include "platform/ContextMenuItem.h"
@@ -408,6 +409,9 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
     m_validationMessage = ValidationMessageClientImpl::create(*this);
     m_page->setValidationMessageClient(m_validationMessage.get());
     provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProviderImpl::create());
+    if (m_client)
+        providePushControllerTo(*m_page, m_client->webPushClient());

[Peter Beverloo, 2014/03/10 13:59:28]

Perhaps you could check the value of the runtime flag here, to avoid creating a
PushController if experimental features are disabled? It won't be accessed
anyway because of ASSERTs elsewhere. Otherwise you could consolidate this block
with the one on lines 418-421, to avoid an extra branch.

[Michael van Ouwerkerk, 2014/03/10 15:12:04]

Done.

+
 
     m_page->makeOrdinary();