Source/modules/pushmessaging/PushMessagingError.cpp - Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/pushmessaging/PushMessagingError.cpp

Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase. Flip flag to experimental. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/pushmessaging/PushMessagingError.h ('K') | « Source/modules/pushmessaging/PushMessagingError.h ('k') | Source/modules/pushmessaging/PushRegistration.h » ('j') | Source/web/WebViewImpl.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "PushMessagingError.h"

	7

	8 namespace WebCore {

	9

	10 String PushMessagingError::errorString(blink::WebPushMessagingError::ErrorType t ype)

	11 {

	12 switch (type) {

	13 case blink::WebPushMessagingError::AbortError:

	14 return "AbortError";

	15 case blink::WebPushMessagingError::UnknownError:

	16 return "UnknownError";

	17 }

	18 ASSERT_NOT_REACHED();

	19 return String();

	20 }

	21 }
	Peter Beverloo 2014/03/10 13:59:28 micro nit: new line, optionally "// namespace WebC micro nit: new line, optionally "// namespace WebCore", but it's quite a short file. Michael van Ouwerkerk 2014/03/10 15:12:04 Done. Show quoted text On 2014/03/10 13:59:28, Peter Beverloo wrote: > micro nit: new line, optionally "// namespace WebCore", but it's quite a short > file. Done.
OLD	NEW