Source/modules/pushmessaging/PushManager.idl - Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/pushmessaging/PushManager.idl

Issue 152763002: DO NOT REVIEW Bindings and plumbing for push messaging API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase. Flip flag to experimental. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/pushmessaging/PushManager.cpp ('K') | « Source/modules/pushmessaging/PushManager.cpp ('k') | Source/modules/pushmessaging/PushMessagingError.h » ('j') | Source/modules/pushmessaging/PushMessagingError.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 RuntimeEnabled=WebAnimationsAPI,	6 NoInterfaceObject,

7 ] partial interface Document {	7 ] interface PushManager {

8 readonly attribute Timeline timeline;	8 [CallWith=ExecutionContext, ImplementedAs=registerPushMessaging] Promise reg ister(DOMString channelname);
	Peter Beverloo 2014/03/10 13:59:28 Add a FIXME (possibly with assigned bug) about the Add a FIXME (possibly with assigned bug) about the rest of the API needing implementation, specifically unregister() and registrations()? Peter Beverloo 2014/03/10 13:59:28 I thought we were dropping the \|channelName\| attri I thought we were dropping the \|channelName\| attribute as it's just syntactic sugar? Michael van Ouwerkerk 2014/03/10 15:12:04 Maybe, it wasn't clear to me whether we'd partiall Show quoted text On 2014/03/10 13:59:28, Peter Beverloo wrote: > I thought we were dropping the \|channelName\| attribute as it's just syntactic > sugar? Maybe, it wasn't clear to me whether we'd partially or completely remove it from the API. Michael van Ouwerkerk 2014/03/10 15:12:04 I think it's implied that one patch does not imple Show quoted text On 2014/03/10 13:59:28, Peter Beverloo wrote: > Add a FIXME (possibly with assigned bug) about the rest of the API needing > implementation, specifically unregister() and registrations()? I think it's implied that one patch does not implement the whole API. The API spec will be referenced from the bug.
9 };	9 };

OLD	NEW