Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1527613006: Use Vector<...>::append(const U*, size_t) in SVGPathByteStream (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Vector<...>::append(const U*, size_t) in SVGPathByteStream This appears to help larger paths a decent amount, while not hurting smaller paths. Payload for this copy is 2-26 bytes. For a ~3.5k character path string this reduced runtime of a setAttribute('d', <path>) micro-benchmark (w/ mostly 10 byte payloads) by roughly 17%. BUG=568735 Committed: https://crrev.com/119dbdc4873edbe693a6b715b9cc53613a7e5721 Cr-Commit-Position: refs/heads/master@{#365365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/svg/SVGPathByteStream.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fs
This seemed like a simple enough change with decent enough improvement - without starting to ...
5 years ago (2015-12-15 14:26:52 UTC) #2
pdr.
On 2015/12/15 at 14:26:52, fs wrote: > This seemed like a simple enough change with ...
5 years ago (2015-12-15 21:52:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527613006/1
5 years ago (2015-12-15 21:55:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 22:45:38 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 22:47:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/119dbdc4873edbe693a6b715b9cc53613a7e5721
Cr-Commit-Position: refs/heads/master@{#365365}

Powered by Google App Engine
This is Rietveld 408576698