Bug fix: Show mouse cursor during full screen share on ChromeOS.

Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
Committed: https://crrev.com/65a833af01fe7588e76e18cd28a86aec8980389d
Cr-Commit-Position: refs/heads/master@{#365594}

[qiangchen, 2015-12-15 23:58:11]

Description was changed from

==========
Bug fix: For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
==========

to

==========
Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
==========

[qiangchen, 2015-12-15 23:59:30]

qiangchen@chromium.org changed reviewers:
+ sergeyu@chromium.org

[qiangchen, 2015-12-16 00:06:28]

qiangchen@chromium.org changed reviewers:
+ isheriff@chromium.org

[qiangchen, 2015-12-16 00:06:28]

Hi, Irfan and Sergey:

    Can you take a look at this CL. It is a simple quick fix.

Qiang

[Sergey Ulanov, 2015-12-16 01:43:36]

lgtm when my comments are addressed

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
File content/browser/media/capture/cursor_renderer_aura.cc (right):

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
content/browser/media/capture/cursor_renderer_aura.cc:80: // not.
Please reword this to make it clear what's going on here. E.g.:
  // If this is not a root window then the cursor should be rendered
  // only when the window is active.

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
content/browser/media/capture/cursor_renderer_aura.cc:81: if
(!window_->IsRootWindow()){
formatting: need a space before {

[qiangchen, 2015-12-16 17:30:05]

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
File content/browser/media/capture/cursor_renderer_aura.cc (right):

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
content/browser/media/capture/cursor_renderer_aura.cc:80: // not.
On 2015/12/16 01:43:36, Sergey Ulanov wrote:
> Please reword this to make it clear what's going on here. E.g.:
>   // If this is not a root window then the cursor should be rendered
>   // only when the window is active.

Done.

https://codereview.chromium.org/1527603005/diff/1/content/browser/media/captu...
content/browser/media/capture/cursor_renderer_aura.cc:81: if
(!window_->IsRootWindow()){
On 2015/12/16 01:43:36, Sergey Ulanov wrote:
> formatting: need a space before {

Done.

[Irfan, 2015-12-16 18:35:05]

lgtm

Did you validate this does the right thing on non-chrome OS for tab mirroring ?

[qiangchen, 2015-12-16 19:04:17]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2015-12-16 19:04:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1527603005/#ps20001
(title: "Reword Comment")

[commit-bot: I haz the power, 2015-12-16 19:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527603005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527603005/20001

[commit-bot: I haz the power, 2015-12-16 19:57:02]

Description was changed from

==========
Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
==========

to

==========
Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
==========

[commit-bot: I haz the power, 2015-12-16 19:57:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 19:58:10]

Description was changed from

==========
Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841
==========

to

==========
Bug fix: Show mouse cursor during full screen share on ChromeOS.

For R48, On chrome book we found when doing screen share of the
whole screen, the mouse cursor was not captured. This is caused by a bug
we consider the root window as inactive. In this CL, we fix this bug,
and then mouse cursor is shared when doing full screen share.

BUG=568841

Committed: https://crrev.com/65a833af01fe7588e76e18cd28a86aec8980389d
Cr-Commit-Position: refs/heads/master@{#365594}
==========

[commit-bot: I haz the power, 2015-12-16 19:58:11]

Patchset 2 (id:??) landed as
https://crrev.com/65a833af01fe7588e76e18cd28a86aec8980389d
Cr-Commit-Position: refs/heads/master@{#365594}