Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1527603002:
Remove ScopedVector from test_reg_util_win (Closed)
|
Created:
5 years ago by kimwjdalsl Modified:
5 years ago CC:
chromium-reviews, vmpstr+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector from test_reg_util_win
BUG=554289
Committed: https://crrev.com/ab64c48ee3d073ed953638e8f3930a4c2c3c5e14
Cr-Commit-Position: refs/heads/master@{#365399}
Patch Set 1 #
Total comments: 2
Patch Set 2 : clang format DONE #Patch Set 3 : presubmit DONE #
Messages
Total messages: 30 (13 generated)
The CQ bit was checked by kimwjdalsl@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Remove ScopedVector from test_reg_util_win BUG=554289 ========== to ========== Remove ScopedVector from test_reg_util_win BUG=554289 ==========
kimwjdalsl@gmail.com changed reviewers: + brettw@chromium.org, danakj@chromium.org
Could you please review this patch? It's for Issue 554289: [c++11 library] Remove ScopedVector
kimwjdalsl@gmail.com changed reviewers: + phajdan.jr@chromium.org
LGTM
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/1527603002/diff/1/base/test/test_reg_util_win.cc File base/test/test_reg_util_win.cc (right): https://codereview.chromium.org/1527603002/diff/1/base/test/test_reg_util_win... base/test/test_reg_util_win.cc:100: overrides_.push_back(make_scoped_ptr(new ScopedRegistryKeyOverride(override, key_path))); Run clang format please
https://codereview.chromium.org/1527603002/diff/1/base/test/test_reg_util_win.cc File base/test/test_reg_util_win.cc (right): https://codereview.chromium.org/1527603002/diff/1/base/test/test_reg_util_win... base/test/test_reg_util_win.cc:100: overrides_.push_back(make_scoped_ptr(new ScopedRegistryKeyOverride(override, key_path))); On 2015/12/14 20:52:52, danakj (behind on reviews) wrote: > Run clang format please Done.
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/1527603002/#ps20001 (title: "clang format DONE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527603002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
It's my first contribution. so I add my info to AUTHORS.
It's my first contribution. so I add my info to AUTHORS.
Thanks, I see you signed the CLA also. LGTM :)
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527603002/40001
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector from test_reg_util_win BUG=554289 ========== to ========== Remove ScopedVector from test_reg_util_win BUG=554289 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector from test_reg_util_win BUG=554289 ========== to ========== Remove ScopedVector from test_reg_util_win BUG=554289 Committed: https://crrev.com/ab64c48ee3d073ed953638e8f3930a4c2c3c5e14 Cr-Commit-Position: refs/heads/master@{#365399} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ab64c48ee3d073ed953638e8f3930a4c2c3c5e14 Cr-Commit-Position: refs/heads/master@{#365399} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
