Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 1527593002: [debugger] flood function for stepping on throw. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] flood function for stepping on throw. We used to flood the handler when preparing for stepping, even if we may not throw. Instead, we now flood the handler only when we actually throw. This also solves an issue with step-next when we throw and leave the function unexpectedly. In combination with microtasks, this could cause a crash. R=mstarzinger@chromium.org BUG=chromium:568477 LOG=N Committed: https://crrev.com/6d8a2611c0e1ccb9d64456784a5f675534409541 Cr-Commit-Position: refs/heads/master@{#32856}

Patch Set 1 #

Patch Set 2 : blacklist for ignition #

Patch Set 3 : one more item for the black list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -34 lines) Patch
M src/debug/debug.h View 2 chunks +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 5 chunks +30 lines, -23 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-568477-1.js View 1 chunk +54 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-568477-2.js View 2 chunks +21 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-568477-3.js View 1 chunk +56 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-568477-4.js View 2 chunks +21 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (11 generated)
Yang
This is the fix we discussed. Please take a look. Thanks!
5 years ago (2015-12-14 13:52:06 UTC) #1
Michael Starzinger
LGTM. Nice, I like it!
5 years ago (2015-12-14 14:00:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527593002/1
5 years ago (2015-12-14 14:03:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13046)
5 years ago (2015-12-14 14:28:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527593002/20001
5 years ago (2015-12-15 06:22:42 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11505)
5 years ago (2015-12-15 06:55:00 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527593002/20001
5 years ago (2015-12-15 07:10:11 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11506)
5 years ago (2015-12-15 07:36:39 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527593002/40001
5 years ago (2015-12-15 08:03:32 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-15 08:25:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527593002/40001
5 years ago (2015-12-15 09:31:56 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 09:33:05 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-15 09:33:48 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6d8a2611c0e1ccb9d64456784a5f675534409541
Cr-Commit-Position: refs/heads/master@{#32856}

Powered by Google App Engine
This is Rietveld 408576698