Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: test/unittests/compiler/escape-analysis-unittest.cc

Issue 1527533002: [turbofan] Move replacements out of virtual object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-cluster-3
Patch Set: Address comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/escape-analysis-reducer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/escape-analysis-unittest.cc
diff --git a/test/unittests/compiler/escape-analysis-unittest.cc b/test/unittests/compiler/escape-analysis-unittest.cc
index 17e0da44c98e57e6b36f99c9b8c6301f0f1f3872..1ea140651f70093baa6f43b2e6cb257f04ceb45c 100644
--- a/test/unittests/compiler/escape-analysis-unittest.cc
+++ b/test/unittests/compiler/escape-analysis-unittest.cc
@@ -140,11 +140,11 @@ class EscapeAnalysisTest : public GraphTest {
// ---------------------------------Assertion Helper--------------------------
void ExpectReplacement(Node* node, Node* rep) {
- EXPECT_EQ(rep, escape_analysis()->GetReplacement(node, node->id()));
+ EXPECT_EQ(rep, escape_analysis()->GetReplacement(node));
}
void ExpectReplacementPhi(Node* node, Node* left, Node* right) {
- Node* rep = escape_analysis()->GetReplacement(node, node->id());
+ Node* rep = escape_analysis()->GetReplacement(node);
ASSERT_NE(nullptr, rep);
ASSERT_EQ(IrOpcode::kPhi, rep->opcode());
EXPECT_EQ(left, NodeProperties::GetValueInput(rep, 0));
@@ -270,7 +270,7 @@ TEST_F(EscapeAnalysisTest, BranchNonEscape) {
ExpectVirtual(allocation);
ExpectReplacementPhi(load, object1, object2);
- Node* replacement_phi = escape_analysis()->GetReplacement(load, load->id());
+ Node* replacement_phi = escape_analysis()->GetReplacement(load);
Transformation();
« no previous file with comments | « src/compiler/escape-analysis-reducer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698