Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: src/compiler/escape-analysis-reducer.cc

Issue 1527533002: [turbofan] Move replacements out of virtual object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-cluster-3
Patch Set: Address comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/escape-analysis.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/escape-analysis-reducer.cc
diff --git a/src/compiler/escape-analysis-reducer.cc b/src/compiler/escape-analysis-reducer.cc
index 5fa01999c787c0099e03211c4e472a67b33279bd..1fece43fc3d2236adcc703ef7884efcecbab7723 100644
--- a/src/compiler/escape-analysis-reducer.cc
+++ b/src/compiler/escape-analysis-reducer.cc
@@ -49,7 +49,7 @@ Reduction EscapeAnalysisReducer::Reduce(Node* node) {
Reduction EscapeAnalysisReducer::ReduceLoad(Node* node) {
DCHECK(node->opcode() == IrOpcode::kLoadField ||
node->opcode() == IrOpcode::kLoadElement);
- if (Node* rep = escape_analysis()->GetReplacement(node, node->id())) {
+ if (Node* rep = escape_analysis()->GetReplacement(node)) {
if (FLAG_trace_turbo_escape) {
PrintF("Replaced #%d (%s) with #%d (%s)\n", node->id(),
node->op()->mnemonic(), rep->id(), rep->op()->mnemonic());
@@ -116,10 +116,10 @@ Reduction EscapeAnalysisReducer::ReduceReferenceEqual(Node* node) {
Node* right = NodeProperties::GetValueInput(node, 1);
if (escape_analysis()->IsVirtual(left)) {
if (escape_analysis()->IsVirtual(right)) {
- if (Node* rep = escape_analysis()->GetReplacement(node, left->id())) {
+ if (Node* rep = escape_analysis()->GetReplacement(left)) {
left = rep;
}
- if (Node* rep = escape_analysis()->GetReplacement(node, right->id())) {
+ if (Node* rep = escape_analysis()->GetReplacement(right)) {
right = rep;
}
// TODO(sigurds): What to do if either is a PHI?
« no previous file with comments | « src/compiler/escape-analysis.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698