[turbofan] Move replacements out of virtual object

test/unittests/compiler/escape-analysis-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bit-vector.h"
 #include "src/compiler/escape-analysis.h"
 #include "src/compiler/escape-analysis-reducer.h"
 #include "src/compiler/graph-visualizer.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-properties.h"
@@ skipping 122 matching lines @@
 
   FieldAccess AccessAtIndex(int offset) {
     FieldAccess access = {kTaggedBase, offset, MaybeHandle<Name>(), Type::Any(),
                           MachineType::AnyTagged()};
     return access;
   }
 
   // ---------------------------------Assertion Helper--------------------------
 
   void ExpectReplacement(Node* node, Node* rep) {
-    EXPECT_EQ(rep, escape_analysis()->GetReplacement(node, node->id()));
+    EXPECT_EQ(rep, escape_analysis()->GetReplacement(node));
   }
 
   void ExpectReplacementPhi(Node* node, Node* left, Node* right) {
-    Node* rep = escape_analysis()->GetReplacement(node, node->id());
+    Node* rep = escape_analysis()->GetReplacement(node);
     ASSERT_NE(nullptr, rep);
     ASSERT_EQ(IrOpcode::kPhi, rep->opcode());
     EXPECT_EQ(left, NodeProperties::GetValueInput(rep, 0));
     EXPECT_EQ(right, NodeProperties::GetValueInput(rep, 1));
   }
 
   void ExpectVirtual(Node* node) {
     EXPECT_TRUE(node->opcode() == IrOpcode::kAllocate ||
                 node->opcode() == IrOpcode::kFinishRegion);
     EXPECT_TRUE(escape_analysis()->IsVirtual(node));
@@ skipping 105 matching lines @@
   Node* effect2 = Store(AccessAtIndex(0), allocation, object2, finish, ifTrue);
   Node* merge = Merge2(ifFalse, ifTrue);
   Node* phi = graph()->NewNode(common()->EffectPhi(2), effect1, effect2, merge);
   Node* load = Load(AccessAtIndex(0), finish, phi, merge);
   Node* result = Return(load, phi);
   EndGraph();
   Analysis();
 
   ExpectVirtual(allocation);
   ExpectReplacementPhi(load, object1, object2);
-  Node* replacement_phi = escape_analysis()->GetReplacement(load, load->id());
+  Node* replacement_phi = escape_analysis()->GetReplacement(load);
 
   Transformation();
 
   ASSERT_EQ(replacement_phi, NodeProperties::GetValueInput(result, 0));
 }
 
 
 TEST_F(EscapeAnalysisTest, DanglingLoadOrder) {
   Node* object1 = Constant(1);
   Node* object2 = Constant(2);
@@ skipping 12 matching lines @@
   ExpectReplacement(load2, object1);
 
   Transformation();
 
   ASSERT_EQ(object1, NodeProperties::GetValueInput(result, 0));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8