Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 152753002: Update input[type=range]'s step base handling to match spec. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update input[type=range]'s step base handling to match spec. The HTML spec recently shifted to using 'value' as the first fallback option for an input element's "step base" (if no 'min' attribute), http://www.whatwg.org/specs/web-apps/current-work/#concept-input-min-zero Also bring type=range elements into line with that, including using that step base when clamping values to the supported range. R= BUG=339194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166367

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -52 lines) Patch
M LayoutTests/fast/forms/range/range-stepup-stepdown.html View 3 chunks +77 lines, -47 lines 0 comments Download
M LayoutTests/fast/forms/range/range-stepup-stepdown-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +3 lines, -2 lines 3 comments Download
M Source/core/html/forms/StepRange.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
When you have a moment, please take a look. Came across some issues with stepUp()/stepDown() ...
6 years, 10 months ago (2014-02-03 16:42:56 UTC) #1
sof
https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp File Source/core/html/forms/RangeInputType.cpp (left): https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp#oldcode130 Source/core/html/forms/RangeInputType.cpp:130: const AtomicString& precisionValue = element().fastGetAttribute(precisionAttr); I see there's a ...
6 years, 10 months ago (2014-02-03 18:36:08 UTC) #2
tkent
lgtm https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp File Source/core/html/forms/RangeInputType.cpp (left): https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp#oldcode130 Source/core/html/forms/RangeInputType.cpp:130: const AtomicString& precisionValue = element().fastGetAttribute(precisionAttr); On 2014/02/03 18:36:09, ...
6 years, 10 months ago (2014-02-04 00:49:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/152753002/1
6 years, 10 months ago (2014-02-04 00:50:07 UTC) #4
sof
https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp File Source/core/html/forms/RangeInputType.cpp (left): https://codereview.chromium.org/152753002/diff/1/Source/core/html/forms/RangeInputType.cpp#oldcode130 Source/core/html/forms/RangeInputType.cpp:130: const AtomicString& precisionValue = element().fastGetAttribute(precisionAttr); On 2014/02/04 00:49:56, tkent ...
6 years, 10 months ago (2014-02-04 06:26:42 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 08:05:09 UTC) #6
Message was sent while issue was closed.
Change committed as 166367

Powered by Google App Engine
This is Rietveld 408576698