Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1527513002: Oilpan: support OSX thread stack size discovery. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: support OSX thread stack size discovery. We do know enough about OSX stack sizes to be able to work around bugginess of 10.9's pthread_get_stacksize_np(). R=haraken BUG=569480 Committed: https://crrev.com/748d2a9a91f91b8ab342597bd212dac9c7b1e06d Cr-Commit-Position: refs/heads/master@{#364996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look.
5 years ago (2015-12-14 09:03:29 UTC) #3
haraken
LGTM, nice detective work!
5 years ago (2015-12-14 09:11:00 UTC) #4
sof
On 2015/12/14 09:11:00, haraken wrote: > LGTM, nice detective work! I'm guessing incidental changes to ...
5 years ago (2015-12-14 09:32:34 UTC) #5
sof
mac_blink_oilpan_dbg is happy; will land, but watch out for trouble (wrt Canary stability.)
5 years ago (2015-12-14 10:31:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527513002/1
5 years ago (2015-12-14 10:33:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 10:37:26 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-14 10:38:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/748d2a9a91f91b8ab342597bd212dac9c7b1e06d
Cr-Commit-Position: refs/heads/master@{#364996}

Powered by Google App Engine
This is Rietveld 408576698