Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add files back Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bookmarks/DEPS ('k') | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_model.h" 5 #include "chrome/browser/bookmarks/bookmark_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <functional> 8 #include <functional>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/bind_helpers.h" 11 #include "base/bind_helpers.h"
12 #include "base/i18n/string_compare.h" 12 #include "base/i18n/string_compare.h"
13 #include "base/json/json_string_value_serializer.h" 13 #include "base/json/json_string_value_serializer.h"
14 #include "base/sequenced_task_runner.h" 14 #include "base/sequenced_task_runner.h"
15 #include "base/string_util.h" 15 #include "base/string_util.h"
16 #include "base/utf_string_conversions.h" 16 #include "base/utf_string_conversions.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "build/build_config.h" 18 #include "build/build_config.h"
19 #include "chrome/browser/bookmarks/bookmark_expanded_state_tracker.h" 19 #include "chrome/browser/bookmarks/bookmark_expanded_state_tracker.h"
20 #include "chrome/browser/bookmarks/bookmark_index.h" 20 #include "chrome/browser/bookmarks/bookmark_index.h"
21 #include "chrome/browser/bookmarks/bookmark_model_observer.h" 21 #include "chrome/browser/bookmarks/bookmark_model_observer.h"
22 #include "chrome/browser/bookmarks/bookmark_storage.h" 22 #include "chrome/browser/bookmarks/bookmark_storage.h"
23 #include "chrome/browser/bookmarks/bookmark_utils.h" 23 #include "chrome/browser/bookmarks/bookmark_utils.h"
24 #include "chrome/browser/favicon/favicon_changed_details.h"
24 #include "chrome/browser/favicon/favicon_service.h" 25 #include "chrome/browser/favicon/favicon_service.h"
25 #include "chrome/browser/favicon/favicon_service_factory.h" 26 #include "chrome/browser/favicon/favicon_service_factory.h"
26 #include "chrome/browser/favicon/favicon_types.h" 27 #include "chrome/browser/favicon/favicon_types.h"
27 #include "chrome/browser/history/history_notifications.h"
28 #include "chrome/browser/history/history_service.h" 28 #include "chrome/browser/history/history_service.h"
29 #include "chrome/browser/history/history_service_factory.h" 29 #include "chrome/browser/history/history_service_factory.h"
30 #include "chrome/browser/profiles/profile.h" 30 #include "chrome/browser/profiles/profile.h"
31 #include "chrome/common/chrome_notification_types.h" 31 #include "chrome/common/chrome_notification_types.h"
32 #include "content/public/browser/notification_details.h" 32 #include "content/public/browser/notification_details.h"
33 #include "content/public/browser/notification_source.h" 33 #include "content/public/browser/notification_source.h"
34 #include "grit/generated_resources.h" 34 #include "grit/generated_resources.h"
35 #include "ui/base/l10n/l10n_util.h" 35 #include "ui/base/l10n/l10n_util.h"
36 #include "ui/gfx/favicon_size.h" 36 #include "ui/gfx/favicon_size.h"
37 #include "ui/gfx/image/image_util.h" 37 #include "ui/gfx/image/image_util.h"
(...skipping 909 matching lines...) Expand 10 before | Expand all | Expand 10 after
947 node->set_favicon_load_task_id(CancelableTaskTracker::kBadTaskId); 947 node->set_favicon_load_task_id(CancelableTaskTracker::kBadTaskId);
948 } 948 }
949 } 949 }
950 950
951 void BookmarkModel::Observe(int type, 951 void BookmarkModel::Observe(int type,
952 const content::NotificationSource& source, 952 const content::NotificationSource& source,
953 const content::NotificationDetails& details) { 953 const content::NotificationDetails& details) {
954 switch (type) { 954 switch (type) {
955 case chrome::NOTIFICATION_FAVICON_CHANGED: { 955 case chrome::NOTIFICATION_FAVICON_CHANGED: {
956 // Prevent the observers from getting confused for multiple favicon loads. 956 // Prevent the observers from getting confused for multiple favicon loads.
957 content::Details<history::FaviconChangeDetails> favicon_details(details); 957 content::Details<FaviconChangedDetails> favicon_details(details);
958 for (std::set<GURL>::const_iterator i = favicon_details->urls.begin(); 958 for (std::set<GURL>::const_iterator i = favicon_details->urls.begin();
959 i != favicon_details->urls.end(); ++i) { 959 i != favicon_details->urls.end(); ++i) {
960 std::vector<const BookmarkNode*> nodes; 960 std::vector<const BookmarkNode*> nodes;
961 GetNodesByURL(*i, &nodes); 961 GetNodesByURL(*i, &nodes);
962 for (size_t i = 0; i < nodes.size(); ++i) { 962 for (size_t i = 0; i < nodes.size(); ++i) {
963 // Got an updated favicon, for a URL, do a new request. 963 // Got an updated favicon, for a URL, do a new request.
964 BookmarkNode* node = AsMutable(nodes[i]); 964 BookmarkNode* node = AsMutable(nodes[i]);
965 node->InvalidateFavicon(); 965 node->InvalidateFavicon();
966 CancelPendingFaviconLoadRequests(node); 966 CancelPendingFaviconLoadRequests(node);
967 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_, 967 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
(...skipping 26 matching lines...) Expand all
994 BookmarkPermanentNode* bb_node = 994 BookmarkPermanentNode* bb_node =
995 CreatePermanentNode(BookmarkNode::BOOKMARK_BAR); 995 CreatePermanentNode(BookmarkNode::BOOKMARK_BAR);
996 BookmarkPermanentNode* other_node = 996 BookmarkPermanentNode* other_node =
997 CreatePermanentNode(BookmarkNode::OTHER_NODE); 997 CreatePermanentNode(BookmarkNode::OTHER_NODE);
998 BookmarkPermanentNode* mobile_node = 998 BookmarkPermanentNode* mobile_node =
999 CreatePermanentNode(BookmarkNode::MOBILE); 999 CreatePermanentNode(BookmarkNode::MOBILE);
1000 return new BookmarkLoadDetails(bb_node, other_node, mobile_node, 1000 return new BookmarkLoadDetails(bb_node, other_node, mobile_node,
1001 new BookmarkIndex(profile_), 1001 new BookmarkIndex(profile_),
1002 next_node_id_); 1002 next_node_id_);
1003 } 1003 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/DEPS ('k') | chrome/browser/bookmarks/bookmark_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698