bookmarks: Get rid of the dependency on history_notifications.h

chrome/browser/history/history_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The history system runs on a background thread so that potentially slow
 // database operations don't delay the browser. This backend processing is
 // represented by HistoryBackend. The HistoryService's job is to dispatch to
 // that thread.
 //
 // Main thread                       History thread
@@ skipping 22 matching lines @@
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/thread.h"
 #include "base/time.h"
 #include "chrome/browser/autocomplete/history_url_provider.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/favicon/favicon_changed_details.h"
 #include "chrome/browser/favicon/imported_favicon_usage.h"
 #include "chrome/browser/history/download_row.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/history/history_notifications.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/history/in_memory_database.h"
 #include "chrome/browser/history/in_memory_history_backend.h"
 #include "chrome/browser/history/in_memory_url_index.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/history/visit_database.h"
@@ skipping 101 matching lines @@
 
   virtual void SetInMemoryBackend(int backend_id,
       history::InMemoryHistoryBackend* backend) OVERRIDE {
     // Send the backend to the history service on the main thread.
     service_task_runner_->PostTask(
         FROM_HERE,
         base::Bind(&HistoryService::SetInMemoryBackend, history_service_,
                    backend_id, backend));
   }
 
+  virtual void SendFaviconChangedNotification(
+      chrome::FaviconChangedDetails* details) OVERRIDE {
+    // Send the notification on the history thread.
+    if (content::NotificationService::current()) {
+      content::NotificationService::current()->Notify(
+          chrome::NOTIFICATION_FAVICON_CHANGED,
+          content::Source<Profile>(profile_),
+          content::Details<chrome::FaviconChangedDetails>(details));
+    }
+    // Send the notification to the history service on the main thread.
+    service_task_runner_->PostTask(
+        FROM_HERE,
+        base::Bind(&HistoryService::SendFaviconChangedNotificationHelper,
+                   history_service_, base::Owned(details)));
+  }
+
   virtual void BroadcastNotifications(
       int type,
       history::HistoryDetails* details) OVERRIDE {
     // Send the notification on the history thread.
     if (content::NotificationService::current()) {
       content::Details<history::HistoryDetails> det(details);
       content::NotificationService::current()->Notify(
           type, content::Source<Profile>(profile_), det);
     }
     // Send the notification to the history service on the main thread.
@@ skipping 983 matching lines @@
         web_history->ExpireHistoryBetween(
             restrict_urls, begin_time, end_time,
             base::Bind(&ExpireWebHistoryComplete));
 
     // The request will be freed when the callback is called.
     CHECK(request.release());
   }
   ExpireHistoryBetween(restrict_urls, begin_time, end_time, callback, tracker);
 }
 
+void HistoryService::SendFaviconChangedNotificationHelper(
+    chrome::FaviconChangedDetails* details) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  // TODO(evanm): this is currently necessitated by generate_profile, which
+  // runs without a browser process. generate_profile should really create
+  // a browser process, at which point this check can then be nuked.
+  if (!g_browser_process)
+    return;
+
+  if (!thread_)
+    return;
+
+  // The source of all of our notifications is the profile. Note that this
+  // pointer is NULL in unit tests.
+  content::Source<Profile> source(profile_);
+
+  // The details object just contains the pointer to the object that the
+  // backend has allocated for us. The receiver of the notification will cast
+  // this to the proper type.
+  content::Details<chrome::FaviconChangedDetails> det(details);
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_FAVICON_CHANGED, source, det);
+}
+
 void HistoryService::BroadcastNotificationsHelper(
     int type,
     history::HistoryDetails* details) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // TODO(evanm): this is currently necessitated by generate_profile, which
   // runs without a browser process. generate_profile should really create
   // a browser process, at which point this check can then be nuked.
   if (!g_browser_process)
     return;
 
@@ skipping 94 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   visit_database_observers_.RemoveObserver(observer);
 }
 
 void HistoryService::NotifyVisitDBObserversOnAddVisit(
     const history::BriefVisitInfo& info) {
   DCHECK(thread_checker_.CalledOnValidThread());
   FOR_EACH_OBSERVER(history::VisitDatabaseObserver, visit_database_observers_,
                     OnAddVisit(info));
 }