Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1527453003: Fix ImageResource null-check in LayoutImage::foregroundIsKnownToBeOpaqueInRect (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
davve, f(malita), jbroman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ImageResource null-check in LayoutImage::foregroundIsKnownToBeOpaqueInRect Make sure m_imageResource->cachedImage() is non-null before dereferencing even for the use in the context of the TRACE_EVENT. BUG=569624 Committed: https://crrev.com/720cb8c490ebe7c6a8486c564e1c130339859ebd Cr-Commit-Position: refs/heads/master@{#365097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jbroman
lgtm
5 years ago (2015-12-14 20:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527453003/1
5 years ago (2015-12-14 20:37:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 21:20:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/720cb8c490ebe7c6a8486c564e1c130339859ebd Cr-Commit-Position: refs/heads/master@{#365097}
5 years ago (2015-12-14 21:21:09 UTC) #9
davve
5 years ago (2015-12-15 08:00:13 UTC) #10
Message was sent while issue was closed.
lgtm post-commit.

Powered by Google App Engine
This is Rietveld 408576698