Deferred GIF image decodes should report decode failures

third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 52 matching lines @@
     if (info.width() != getInfo().width() || info.height() != getInfo().height())
         return false;
 
     if (info.colorType() != getInfo().colorType()) {
         // blink::ImageFrame may have changed the owning SkBitmap to kOpaque_SkAlphaType after fully decoding the image frame,
         // so if we see a request for opaque, that is ok even if our initial alpha type was not opaque.
         return false;
     }
 
     PlatformInstrumentation::willDecodeLazyPixelRef(m_generationId);
-    bool decoded = m_frameGenerator->decodeAndScale(getInfo(), m_frameIndex, pixels, rowBytes);
+    bool decoded = m_frameGenerator->decodeAndScale(m_frameIndex, getInfo(), pixels, rowBytes);
     PlatformInstrumentation::didDecodeLazyPixelRef();
 
     return decoded;
 }
 
 bool DecodingImageGenerator::onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3], SkYUVColorSpace* colorSpace)
 {
     if (!m_canYUVDecode)
         return false;
 
     bool requestingYUVSizes = !planes || !planes[0];
 
     TRACE_EVENT1("blink", "DecodingImageGenerator::getYUV8Planes", requestingYUVSizes ? "sizes" : "frame index", static_cast<int>(m_frameIndex));
 
     if (requestingYUVSizes)
         return m_frameGenerator->getYUVComponentSizes(sizes);
 
     if (colorSpace)
         *colorSpace = kJPEG_SkYUVColorSpace;
 
     PlatformInstrumentation::willDecodeLazyPixelRef(m_generationId);
-    bool decoded = m_frameGenerator->decodeToYUV(sizes, planes, rowBytes);
+    bool decoded = m_frameGenerator->decodeToYUV(m_frameIndex, sizes, planes, rowBytes);
     PlatformInstrumentation::didDecodeLazyPixelRef();
 
     return decoded;
 }
 
 SkImageGenerator* DecodingImageGenerator::create(SkData* data)
 {
     RefPtr<SharedBuffer> buffer = SharedBuffer::create(data->bytes(), data->size());
 
     // We just need the size of the image, so we have to temporarily create an ImageDecoder. Since
@@ skipping 10 matching lines @@
     const SkImageInfo info = SkImageInfo::MakeN32Premul(size.width(), size.height());
 
     RefPtr<ImageFrameGenerator> frame = ImageFrameGenerator::create(SkISize::Make(size.width(), size.height()), buffer, true, false);
     if (!frame)
         return 0;
 
     return new DecodingImageGenerator(frame, info, 0);
 }
 
 } // namespace blink