Better error checking in git freeze

Better error checking in git freeze

R=iannucci@chromium.org
BUG=567157
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/96e179bba0f81a12ed57c9840f1ad4b060bc20cd

[agable, 2015-12-16 18:29:10]

This doesn't meet coverage. Do you have advice for how to test it? I'm worried
about creating a file, making it unreadable, hitting this codepath, and then
deleting it. Seems like a recipe for leaving files behind and making the tests
flaky.

[agable, 2015-12-16 18:33:03]

On 2015/12/16 at 18:29:10, agable wrote:
> This doesn't meet coverage. Do you have advice for how to test it? I'm worried
about creating a file, making it unreadable, hitting this codepath, and then
deleting it. Seems like a recipe for leaving files behind and making the tests
flaky.

Also, I can't use Python's os.fchmod on Windows, and os.chmod can't make a
Windows file unreadable (just unwriteable). So...

[iannucci, 2015-12-21 15:55:20]

On 2015/12/16 at 18:29:10, agable wrote:
> This doesn't meet coverage. Do you have advice for how to test it? I'm worried
about creating a file, making it unreadable, hitting this codepath, and then
deleting it. Seems like a recipe for leaving files behind and making the tests
flaky.

If you have the setUp test method always +w and rm it, it shouldn't be flaky. I
don't know of a better way to test it though.

[iannucci, 2015-12-21 15:56:02]

On 2015/12/16 at 18:33:03, agable wrote:
> On 2015/12/16 at 18:29:10, agable wrote:
> > This doesn't meet coverage. Do you have advice for how to test it? I'm
worried about creating a file, making it unreadable, hitting this codepath, and
then deleting it. Seems like a recipe for leaving files behind and making the
tests flaky.
> 
> Also, I can't use Python's os.fchmod on Windows, and os.chmod can't make a
Windows file unreadable (just unwriteable). So...

I would expect this error to be a lot more rare on windows, because tools and
people aren't used to `chmod -w` stuff.

[iannucci, 2015-12-21 15:56:31]

besides lack of test, this looks good though.

[agable, 2016-06-16 16:09:29]

PTAL, added a test and rebased on top of other git-freeze CLs.

[agable, 2016-06-21 14:11:37]

agable@chromium.org changed reviewers:
+ maruel@chromium.org

[agable, 2016-06-21 14:11:38]

+maruel since iannucci@ is on vacation

[M-A Ruel, 2016-06-21 14:19:13]

rs lgtm

[agable, 2016-06-24 17:29:07]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2016-06-24 17:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:32:54]

Description was changed from

==========
Better error checking in git freeze

R=iannucci@chromium.org
BUG=567157
==========

to

==========
Better error checking in git freeze

R=iannucci@chromium.org
BUG=567157

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/96e179bba0f81a...
==========

[commit-bot: I haz the power, 2016-06-24 17:32:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/96e179bba0f81a...