Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1527393002: Don't produce [references] in GitHub-like code blocks in comments. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't produce [references] in GitHub-like code blocks in comments. Mostly for the cases when we would like to demonstrate use or lists or maps: `a[i] == b[i]`. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c19e958822a2941a4a5c90219a61a00d60c92a35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 6 chunks +28 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-16 18:26:37 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-16 18:31:45 UTC) #2
scheglov
5 years ago (2015-12-16 18:32:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c19e958822a2941a4a5c90219a61a00d60c92a35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698