Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Patch by Scott Hancher

BUG=
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/816f242158f5a7002a751a974e14e6a9ef902e31

[ivanpe, 2015-12-16 21:36:35]

Description was changed from

==========
Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Patch by Scott Hancher

BUG=
==========

to

==========
Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Patch by Scott Hancher

BUG=
==========

[ivanpe, 2015-12-16 21:36:35]

ivanpe@chromium.org changed reviewers:
+ mark@chromium.org, ted.mielczarek@gmail.com

[Mark Mentovai, 2015-12-17 22:44:47]

LGTM, I guess. I’m surprised that you’re allowed to read this file on iOS. (I’m
assuming that this is being done for iOS.)

[Mark Mentovai, 2015-12-17 23:09:21]

You can also do what Apple does in the similar function
(_CFCopyVersionDictionary()) in CF itself:
http://opensource.apple.com/source/CF/CF-1153.18/CFUtilities.c

[seh1, 2015-12-17 23:11:49]

On 2015/12/17 22:44:47, Mark Mentovai wrote:
> LGTM, I guess. I’m surprised that you’re allowed to read this file on iOS.
(I’m
> assuming that this is being done for iOS.)

Some complicated BUILD dependencies are sucking it in and it's yielding a build
warning, and I don't like build warnings:) I found it odd too, but I'm not a
BUILD expert, so it seemed easier to just fix the issue and everyone benefits.

[seh1, 2015-12-17 23:14:25]

On 2015/12/17 23:09:21, Mark Mentovai wrote:
> You can also do what Apple does in the similar function
> (_CFCopyVersionDictionary()) in CF itself:
> http://opensource.apple.com/source/CF/CF-1153.18/CFUtilities.c

Correct me if I'm wrong, but that uses the deprecated function,
CFURLCreateDataAndPropertiesFromResource. The code just quiets the deprecated
warning.

[Mark Mentovai, 2015-12-17 23:17:44]

That’s right. I was just providing a less-code alternative that matches what
Apple does when they get this data.

I don’t really care which option you choose. This code is dead to me anyway. :)

[ivanpe, 2015-12-18 18:25:58]

On 2015/12/17 23:17:44, Mark Mentovai wrote:
> That’s right. I was just providing a less-code alternative that matches what
> Apple does when they get this data.
> 
> I don’t really care which option you choose. This code is dead to me anyway.
:)

OK then.  I'll go ahead and commit this patch shortly.

[ivanpe, 2015-12-18 18:26:27]

Description was changed from

==========
Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Patch by Scott Hancher

BUG=
==========

to

==========
Remove use of deprecated CFURLCreateDataAndPropertiesFromResource function.

Patch by Scott Hancher

BUG=
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/816f242158f5a7002a751a9...
==========

[ivanpe, 2015-12-18 18:26:29]

Committed patchset #1 (id:1) manually as
816f242158f5a7002a751a974e14e6a9ef902e31 (presubmit successful).