Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1527343002: Simplify paintFillLayer (Closed)

Created:
5 years ago by davve
Modified:
4 years, 11 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify paintFillLayer paintFillLayer() was only used in one place. Expand the two default arguments and rename paintFillLayerExtended to paintFillLayer. Committed: https://crrev.com/0898c9d8d166ffde65849c3d229e95c8656e6ba9 Cr-Commit-Position: refs/heads/master@{#367659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M third_party/WebKit/Source/core/paint/BoxPainter.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 3 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527343002/1
5 years ago (2015-12-16 15:27:18 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 17:22:28 UTC) #4
davve
Tiny code reduction. Do you think it's worthwhile?
4 years, 11 months ago (2016-01-05 16:07:58 UTC) #8
pdr.
I like it! LGTM
4 years, 11 months ago (2016-01-05 18:04:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527343002/1
4 years, 11 months ago (2016-01-05 18:06:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 22:01:39 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 22:02:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0898c9d8d166ffde65849c3d229e95c8656e6ba9
Cr-Commit-Position: refs/heads/master@{#367659}

Powered by Google App Engine
This is Rietveld 408576698