Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152733002: Clean-up: Replaces obsolete Font/FontList methods. (Closed)

Created:
6 years, 10 months ago by Yuki
Modified:
6 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Visibility:
Public.

Description

Clean-up: Replaces obsolete Font/FontList methods. Replaces obsolete methods of gfx::Font and gfx::FontList with new ones. BUG=265485 TEST=Run ui_unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248887

Patch Set 1 #

Patch Set 2 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/views/notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
Yuki
Could you review this CL? Thanks.
6 years, 10 months ago (2014-02-03 13:21:17 UTC) #1
stevenjb
lgtm
6 years, 10 months ago (2014-02-03 18:12:38 UTC) #2
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 03:04:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/1
6 years, 10 months ago (2014-02-04 03:04:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 03:58:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=145875
6 years, 10 months ago (2014-02-04 03:58:08 UTC) #6
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 04:55:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/1
6 years, 10 months ago (2014-02-04 04:56:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:09:05 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120488
6 years, 10 months ago (2014-02-04 06:09:06 UTC) #10
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 06:13:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/400002
6 years, 10 months ago (2014-02-04 06:13:57 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:35:32 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256252
6 years, 10 months ago (2014-02-04 06:35:32 UTC) #14
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 07:25:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/400002
6 years, 10 months ago (2014-02-04 07:26:54 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:33:08 UTC) #17
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120581
6 years, 10 months ago (2014-02-04 08:33:08 UTC) #18
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 08:38:00 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/400002
6 years, 10 months ago (2014-02-04 08:38:09 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:42:51 UTC) #21
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120626
6 years, 10 months ago (2014-02-04 09:42:52 UTC) #22
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 13:16:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/400002
6 years, 10 months ago (2014-02-04 13:17:56 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 14:19:08 UTC) #25
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120774
6 years, 10 months ago (2014-02-04 14:19:09 UTC) #26
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 14:19:15 UTC) #27
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-05 04:21:27 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152733002/400002
6 years, 10 months ago (2014-02-05 04:25:06 UTC) #29
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:55:56 UTC) #30
Message was sent while issue was closed. 
Change committed as 248887

Powered by Google App Engine
This is Rietveld 408576698