Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527243002: Fix MIPS DSPR2 build failure. (Closed)

Created:
5 years ago by gordanac
Modified:
5 years ago
Reviewers:
fbarchard, fbarchard1
CC:
petar.jovanovic, paul.l...
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Fix MIPS DSPR2 build failure. Fixing the failure: 'TransposeWx8_Fast_MIPS_DSPR2' was not declared in this scope BUG=none R=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/216e93b4e870737eab561cc44cf5bbe3863651a9

Patch Set 1 #

Patch Set 2 : Increase revision number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/rotate_row.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
gordanac
Please take a look. Latest libyuv fails to compile for mips dspr2 as per [1]. ...
5 years ago (2015-12-16 10:30:28 UTC) #2
fbarchard
lgtm Thanks for the patch.
5 years ago (2015-12-16 18:36:39 UTC) #4
fbarchard1
Committed patchset #2 (id:20001) manually as 216e93b4e870737eab561cc44cf5bbe3863651a9 (presubmit successful).
5 years ago (2015-12-16 18:37:45 UTC) #6
gordanac
5 years ago (2015-12-17 11:56:19 UTC) #7
Message was sent while issue was closed. 
On 2015/12/16 18:37:45, fbarchard1 wrote:
> Committed patchset #2 (id:20001) manually as
> 216e93b4e870737eab561cc44cf5bbe3863651a9 (presubmit successful).

Thank you for committing it.

Is it possible to include it in this libyuv roll:
https://codereview.chromium.org/1515693002/?

Powered by Google App Engine
This is Rietveld 408576698