Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1527183004: Remove usage of ScopedJavaLocalRef as a class field (Closed)

Created:
5 years ago by mnaganov (inactive)
Modified:
5 years ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of ScopedJavaLocalRef as a class field BUG=569688 Committed: https://crrev.com/402c7a34d1fcacadf17b0d188cc55e39a9ebae49 Cr-Commit-Position: refs/heads/master@{#365838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/android/java/gin_java_method_invocation_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mnaganov (inactive)
5 years ago (2015-12-16 18:24:25 UTC) #2
Torne
lgtm
5 years ago (2015-12-17 15:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527183004/1
5 years ago (2015-12-17 16:12:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 16:47:53 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 16:49:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/402c7a34d1fcacadf17b0d188cc55e39a9ebae49
Cr-Commit-Position: refs/heads/master@{#365838}

Powered by Google App Engine
This is Rietveld 408576698