mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl ('k') | mojo/public/tools/bindings/pylib/mojom/generate/generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 45d74760e68f1c581eb8bbba4f41804376c4cb37..eb2f03bd20f8696fafb4df23f6822932421a9dd6 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -334,8 +334,7 @@ def TranslateConstants(token, kind):

if token.parent_kind:

name.append(token.parent_kind.name)

if isinstance(token, mojom.EnumValue):

- name.append(

- "%s_%s" % (generator.CamelCaseToAllCaps(token.enum.name), token.name))

+ name.extend([token.enum.name, token.name])

else:

name.append(token.name)

return "::".join(name)

@@ -463,7 +462,6 @@ class Generator(generator.Generator):

"passes_associated_kinds": mojom.PassesAssociatedKinds,

"struct_size": lambda ps: ps.GetTotalSize() + _HEADER_SIZE,

"stylize_method": generator.StudlyCapsToCamel,

- "to_all_caps": generator.CamelCaseToAllCaps,

"under_to_camel": generator.UnderToCamel,

}