mojo/public/cpp/bindings/tests/union_unittest.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/union_unittest.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/sample_service_unittest.cc ('k') | mojo/public/interfaces/bindings/tests/sample_import2.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/union_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/union_unittest.cc b/mojo/public/cpp/bindings/tests/union_unittest.cc

index 461e204ac6c1eb3a2d63de8dde7051ebc7a15e38..60bde4b1d44e9e279c96dab8d07def059b398254 100644

--- a/mojo/public/cpp/bindings/tests/union_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/union_unittest.cc

@@ -87,8 +87,8 @@ TEST(UnionTest, PlainOldDataGetterSetter) {

EXPECT_TRUE(pod->is_f_bool());

EXPECT_EQ(pod->which(), PodUnion::Tag::F_BOOL);

- pod->set_f_enum(AN_ENUM_SECOND);

- EXPECT_EQ(AN_ENUM_SECOND, pod->get_f_enum());

+ pod->set_f_enum(AnEnum::SECOND);

+ EXPECT_EQ(AnEnum::SECOND, pod->get_f_enum());

EXPECT_TRUE(pod->is_f_enum());

EXPECT_EQ(pod->which(), PodUnion::Tag::F_ENUM);

}

@@ -139,7 +139,7 @@ TEST(UnionTest, PodSerialization) {

TEST(UnionTest, EnumSerialization) {

PodUnionPtr pod1(PodUnion::New());

- pod1->set_f_enum(AN_ENUM_SECOND);

+ pod1->set_f_enum(AnEnum::SECOND);

size_t size = GetSerializedSize_(pod1, false);

EXPECT_EQ(16U, size);

@@ -151,7 +151,7 @@ TEST(UnionTest, EnumSerialization) {

PodUnionPtr pod2;

Deserialize_(data, &pod2, nullptr);

- EXPECT_EQ(AN_ENUM_SECOND, pod2->get_f_enum());

+ EXPECT_EQ(AnEnum::SECOND, pod2->get_f_enum());

EXPECT_TRUE(pod2->is_f_enum());

EXPECT_EQ(pod2->which(), PodUnion::Tag::F_ENUM);

}