mojo/public/cpp/bindings/tests/request_response_unittest.cc - Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/request_response_unittest.cc

Issue 1527183003: Change mojo enums to be scoped enums in the generated C++ bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-binding-equals

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc ('k') | mojo/public/cpp/bindings/tests/sample_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/request_response_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/request_response_unittest.cc b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

index 85d2fd42aca9d8d1e3b0bfc602b500531fa75d61..cbc6515d8d1a7c32e03d966e4080ea2f636e27d7 100644

--- a/mojo/public/cpp/bindings/tests/request_response_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

@@ -165,12 +165,12 @@ TEST_F(RequestResponseTest, EchoEnum) {

sample::Enum value;

base::RunLoop run_loop;

- provider->EchoEnum(sample::ENUM_VALUE,

+ provider->EchoEnum(sample::Enum::VALUE,

EnumRecorder(&value, run_loop.QuitClosure()));

run_loop.Run();

- EXPECT_EQ(sample::ENUM_VALUE, value);

+ EXPECT_EQ(sample::Enum::VALUE, value);

}

} // namespace